Bug 145448

Summary: Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[PATCH] For Landing none

Joseph Pecoraro
Reported 2015-05-28 15:54:00 PDT
* SUMMARY NewTabContentView should update button disabled state as other tabs are added/removed * STEPS TO REPRODUCE 1. Open inspector 2. Open Elements and Resources tab 3. Open New Tab tab 4. Close Elements tab => New tab tab should allow creating an Elements tab, currently the button is disabled
Attachments
[PATCH] Proposed Fix (4.14 KB, patch)
2015-05-28 15:56 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (3.96 KB, patch)
2015-05-28 16:16 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-28 15:54:21 PDT
<rdar://problem/21149911>
Joseph Pecoraro
Comment 2 2015-05-28 15:56:42 PDT
Created attachment 253872 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2015-05-28 16:11:53 PDT
Comment on attachment 253872 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253872&action=review Nice! I wasn't sure we would need this. Not really intended for you to keep the New Tab open. > Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:85 > + WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemAdded, this._updateTabItems, this); > + WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemRemoved, this._updateTabItems, this); WebInspector.tabBrowser.tabBar.removeEventListener(null, null, this);
Joseph Pecoraro
Comment 4 2015-05-28 16:16:44 PDT
Created attachment 253874 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2015-05-28 17:19:31 PDT
The commit-queue encountered the following flaky tests while processing attachment 253874 [details]: compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2015-05-28 17:20:59 PDT
Comment on attachment 253874 [details] [PATCH] For Landing Clearing flags on attachment: 253874 Committed r184971: <http://trac.webkit.org/changeset/184971>
Note You need to log in before you can comment on or make changes to this bug.