Bug 145264

Summary: [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145121    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-05-21 06:27:11 PDT
issuse no1: ------------ Now unused parameter warnings are suppressed in WebKit2, but unfortunately the actual mechanism is only works with GCC, but not with Clang. The problem is that the command like looks like "-Wno-unused-parameter -Wall -Wextra" and Clang's -Wextra switches the unused parameter warning back. The proper fix is to put -Wno-unused-parameter after -Wextra. issuse no2: ------------ There are zillion unused parameter warnings in TestNetscapePlugIn, but we can't see them because of a bug: WEBKIT_SET_EXTRA_COMPILER_FLAGS(TestNetscapePlugin) is missing and no warnings options are passed to TestNetscapePlugIn. We should fix it and suppress only the unused parameter warnings there.
Attachments
Patch (3.36 KB, patch)
2015-05-21 06:49 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.38 KB, patch)
2015-05-21 07:10 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-05-21 06:49:25 PDT
Created attachment 253522 [details] Patch
Csaba Osztrogonác
Comment 2 2015-05-21 07:10:33 PDT
Created attachment 253523 [details] Patch typo fixed in changelog
Csaba Osztrogonác
Comment 3 2015-06-01 03:57:53 PDT
Comment on attachment 253523 [details] Patch Clearing flags on attachment: 253523 Committed r185056: <http://trac.webkit.org/changeset/185056>
Csaba Osztrogonác
Comment 4 2015-06-01 03:58:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.