Bug 144872

Summary: Purge PassRefPtr in WebCore/rendering
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Gyuyoung Kim
Reported 2015-05-11 09:06:19 PDT
SSIA
Attachments
Patch (17.81 KB, patch)
2015-05-11 09:07 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (18.48 KB, patch)
2015-05-11 16:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (18.42 KB, patch)
2015-05-11 17:22 PDT, Gyuyoung Kim 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-05-11 09:07:13 PDT
Created attachment 252861 [details] Patch
Gyuyoung Kim
Comment 2 2015-05-11 16:29:18 PDT
Created attachment 252906 [details] Patch
Gyuyoung Kim
Comment 3 2015-05-11 17:22:50 PDT
Created attachment 252911 [details] Patch
Darin Adler
Comment 4 2015-05-11 18:17:38 PDT
Comment on attachment 252911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252911&action=review > Source/WebCore/rendering/RenderThemeSafari.cpp:91 > + return &windowsTheme; // keep the reference of one. I don’t understand the comment “keep the reference of one”. > Source/WebCore/rendering/RenderThemeSafari.cpp:93 > + return &safariTheme; // keep the reference of one. I don’t understand the comment “keep the reference of one”.
Gyuyoung Kim
Comment 5 2015-05-11 19:08:23 PDT
Committed r184147: <http://trac.webkit.org/changeset/184147>
Gyuyoung Kim
Comment 6 2015-05-11 19:09:49 PDT
(In reply to comment #4) > I don’t understand the comment “keep the reference of one”. > > > Source/WebCore/rendering/RenderThemeSafari.cpp:93 > > + return &safariTheme; // keep the reference of one. > > I don’t understand the comment “keep the reference of one”. Landed after removing the unneeded comments.
Note You need to log in before you can comment on or make changes to this bug.