Bug 140876

Summary: security/mixedContent/redirect-https-to-http-iframe-in-main-frame test is the same as security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Minor CC: cgarcia, commit-queue, mcatanzaro, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 140625    
Attachments:
Description Flags
patch
none
Patch none

Michael Catanzaro
Reported 2015-01-25 17:16:17 PST
This looks like a copypaste error. security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html is identical to security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html because it loads https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html. It should be loading https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html.
Attachments
patch (3.13 KB, patch)
2015-01-25 17:24 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.40 KB, patch)
2015-01-27 09:24 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-01-25 17:24:39 PST
Created attachment 245319 [details] patch This one is an easy review.
Darin Adler
Comment 2 2015-01-25 20:07:54 PST
Comment on attachment 245319 [details] patch Not sure why the patch doen’t apply, but EWS says it doesn’t. Could you upload a new one?
Michael Catanzaro
Comment 3 2015-01-27 09:17:03 PST
Oops, the test expectations depend on bug #140621. I will remove the dependency from this patch, and then update the patch in that bug once this one lands.
Michael Catanzaro
Comment 4 2015-01-27 09:24:40 PST
Created attachment 245450 [details] Patch
WebKit Commit Bot
Comment 5 2015-01-28 23:00:39 PST
Comment on attachment 245450 [details] Patch Clearing flags on attachment: 245450 Committed r179336: <http://trac.webkit.org/changeset/179336>
WebKit Commit Bot
Comment 6 2015-01-28 23:00:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.