Bug 138254

Summary:

Update scope related slow path code to use scope register added to opcodes

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akiss, cdumez, commit-queue, dbatyai.u-szeged, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

138252, 138349

Bug Blocks:

136724, 138510

Attachments:

Description	Flags
Patch	mark.lam: review+
buildfix for ARMv7	none
JSC test log from ARMv7 Thumb2	none
Patch updated with supplied build fixes.	mark.lam: review+
minimal example to debug	none
log on r175612 without patch	none
log on r175612 with patch applied	none

Michael Saboff

Reported 2014-10-31 11:12:07 PDT

Update the slow paths to use the scope operands added in <https://bugs.webkit.org/show_bug.cgi?id=138252> and <https://bugs.webkit.org/show_bug.cgi?id=138253>

Attachments
Patch (23.04 KB, patch) 2014-11-03 17:53 PST, Michael Saboff	mark.lam: review+	Details Formatted Diff Diff
buildfix for ARMv7 (1.38 KB, patch) 2014-11-04 00:23 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
JSC test log from ARMv7 Thumb2 (3.36 MB, application/octet-stream) 2014-11-04 01:22 PST, Csaba Osztrogonác	no flags	Details
Patch updated with supplied build fixes. (24.18 KB, patch) 2014-11-04 14:05 PST, Michael Saboff	mark.lam: review+	Details Formatted Diff Diff
minimal example to debug (120 bytes, application/x-javascript) 2014-11-05 02:45 PST, Csaba Osztrogonác	no flags	Details
log on r175612 without patch (310.93 KB, text/plain) 2014-11-05 03:06 PST, Csaba Osztrogonác	no flags	Details
log on r175612 with patch applied (310.94 KB, text/plain) 2014-11-05 03:07 PST, Csaba Osztrogonác	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2014-11-03 17:53:49 PST

Created attachment 240892 [details] Patch

Mark Lam

Comment 2 2014-11-03 19:22:41 PST

Comment on attachment 240892 [details] Patch r=me

Michael Saboff

Comment 3 2014-11-03 19:53:11 PST

Committed r175509: <http://trac.webkit.org/changeset/175509>

Chris Dumez

Comment 4 2014-11-03 20:05:03 PST

Some bots seems to have trouble building after this change: https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release%20%28Build%29/builds/8038/steps/compile-webkit/logs/stdio

WebKit Commit Bot

Comment 5 2014-11-03 20:55:18 PST

Re-opened since this is blocked by bug 138349

Csaba Osztrogonác

Comment 6 2014-11-04 00:23:31 PST

Created attachment 240917 [details] buildfix for ARMv7 This patch fixed the ARMv7 Thumb2 Linux build for me, but got some regressions. I'll upload the detailed results soon. (tests still running)

Csaba Osztrogonác

Comment 7 2014-11-04 01:22:16 PST

Created attachment 240918 [details] JSC test log from ARMv7 Thumb2

Michael Saboff

Comment 8 2014-11-04 14:03:55 PST

(In reply to comment #7) > Created attachment 240918 [details] > JSC test log from ARMv7 Thumb2 Thanks for the build fix. I added it to the original patch and ran tests on ARMv7 Thumb2. I do not see the failures you are seeing. I'm going to post the combined patch. Could you clean build, rerun test and report back with the results?

Michael Saboff

Comment 9 2014-11-04 14:05:33 PST

Created attachment 240946 [details] Patch updated with supplied build fixes. Will run through the EWS bots before landing.

Csaba Osztrogonác

Comment 10 2014-11-05 01:29:48 PST

(In reply to comment #8) > (In reply to comment #7) > > Created attachment 240918 [details] > > JSC test log from ARMv7 Thumb2 > > Thanks for the build fix. I added it to the original patch and ran tests on > ARMv7 Thumb2. I do not see the failures you are seeing. I'm going to post > the combined patch. > > Could you clean build, rerun test and report back with the results? I tried it, the build works fine, but unfortunately the failures is still present on Linux with Thumb2 and ARM instruction set too.

Csaba Osztrogonác

Comment 11 2014-11-05 02:45:51 PST

Created attachment 241015 [details] minimal example to debug $ ./jsc --useLLInt=false --useDFGJIT=false -f foo.js 1.9097962116e-313 expected result: foo_string

Csaba Osztrogonác

Comment 12 2014-11-05 03:06:45 PST

Created attachment 241017 [details] log on r175612 without patch $ ./jsc --useLLInt=false --useDFGJIT=false --dumpGeneratedBytecodes=true --showDisassembly=true -f foo.js

Csaba Osztrogonác

Comment 13 2014-11-05 03:07:24 PST

Created attachment 241018 [details] log on r175612 with patch applied

Michael Saboff

Comment 14 2014-11-07 06:46:21 PST

(In reply to comment #13) > Created attachment 241018 [details] > log on r175612 with patch applied I'll look at the generated assembly today to see what is going on.

Dániel Bátyai

Comment 15 2014-11-07 06:52:10 PST

(In reply to comment #14) > (In reply to comment #13) > > Created attachment 241018 [details] > > log on r175612 with patch applied > > I'll look at the generated assembly today to see what is going on. Hi, we have found the issue already, patch is on the way.

Csaba Osztrogonác

Comment 16 2014-11-07 12:20:05 PST

(In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > Created attachment 241018 [details] > > > log on r175612 with patch applied > > > > I'll look at the generated assembly today to see what is going on. > > Hi, we have found the issue already, patch is on the way. Dániel already fixed the issue in bug138510. It's safe to land this one and then the fix from bug138510.

Mark Lam

Comment 17 2014-11-07 13:32:29 PST

Comment on attachment 240946 [details] Patch updated with supplied build fixes. r=me

Michael Saboff

Comment 18 2014-11-07 13:58:34 PST

Committed r175762: <http://trac.webkit.org/changeset/175762>

Note You need to log in before you can comment on or make changes to this bug.