Bug 136311

Summary: Web Replay: only generate EncodingTraits for enums defined in the target framework
Product: WebKit Reporter: Brian Burg <burg>
Component: WebCore Misc.Assignee: Brian Burg <burg>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Proposed Fix none

Brian Burg
Reported 2014-08-27 14:23:45 PDT
Currently it will unconditionally generate enum encoding traits if the enum is referenced in the Inputs.json file, even if it's from a different namespace and also in another framework's Inputs.json file.
Attachments
WIP (13.96 KB, patch)
2015-01-14 14:43 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (57.21 KB, patch)
2015-01-14 17:37 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2015-01-14 14:43:55 PST
Created attachment 244639 [details] WIP
Brian Burg
Comment 2 2015-01-14 17:37:46 PST
Created attachment 244668 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2015-01-14 17:40:17 PST
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2015-01-14 17:40:27 PST
Attachment 244668 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:785: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:60: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:81: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:71: The parameter name "phase" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brian Burg
Comment 5 2015-01-18 23:00:28 PST
Will fix these in one patch, since enums and inputs require similar filtering. *** This bug has been marked as a duplicate of bug 136312 ***
Note You need to log in before you can comment on or make changes to this bug.