Bug 133918

Summary: DFG AI and constant folder should be able to precisely prune MultiGetByOffset/MultiPutByOffset even if the base structure abstract value is not a singleton
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 133935, 133947, 133985    
Bug Blocks: 133229    
Attachments:
Description Flags
work in progress
none
more
none
rebased
none
it compiles!
none
almost done
none
ready for review mhahnenberg: review+

Filip Pizlo
Reported 2014-06-14 14:41:59 PDT
...
Attachments
work in progress (13.47 KB, patch)
2014-06-14 14:42 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (19.17 KB, patch)
2014-06-16 21:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
rebased (21.75 KB, patch)
2014-06-17 20:21 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it compiles! (28.96 KB, patch)
2014-06-17 21:06 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost done (61.91 KB, patch)
2014-06-18 13:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
ready for review (61.86 KB, patch)
2014-06-18 13:43 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-06-14 14:42:47 PDT
Created attachment 233125 [details] work in progress
Filip Pizlo
Comment 2 2014-06-16 21:05:18 PDT
Created attachment 233214 [details] more
Filip Pizlo
Comment 3 2014-06-17 20:21:25 PDT
Created attachment 233279 [details] rebased
Filip Pizlo
Comment 4 2014-06-17 21:06:11 PDT
Created attachment 233283 [details] it compiles! And fails all of the interesting tests.
Filip Pizlo
Comment 5 2014-06-18 13:29:30 PDT
Created attachment 233321 [details] almost done
Filip Pizlo
Comment 6 2014-06-18 13:43:24 PDT
Created attachment 233322 [details] ready for review
Mark Hahnenberg
Comment 7 2014-06-18 14:25:29 PDT
Comment on attachment 233322 [details] ready for review View in context: https://bugs.webkit.org/attachment.cgi?id=233322&action=review r=me > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:130 > + != node->transition()->next) Weird line break.
Filip Pizlo
Comment 8 2014-06-18 21:35:59 PDT
Landed in http://trac.webkit.org/changeset/170141
Note You need to log in before you can comment on or make changes to this bug.