Bug 132165

Summary:

Convert OwnPtr and PassOwnPtr uses to std::unique_ptr in Supplement

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

DOM

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, benjamin, buildbot, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, gyuyoung.kim, hta, jer.noble, jsbell, kangil.han, philipj, rniwa, sergio, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
WIP	none
WIP-2	none
WIP-3	none
WIP-4	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Patch	none

Gyuyoung Kim

Reported 2014-04-24 20:34:25 PDT

As a step to convert from OwnPtr|PassOwnPtr to std::unique_ptr, Supplement also needs to convert it. Patch is coming.

Attachments
WIP (40.82 KB, patch) 2014-04-25 04:13 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-2 (44.38 KB, patch) 2014-04-28 03:04 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-3 (45.02 KB, patch) 2014-04-28 16:11 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
WIP-4 (50.20 KB, patch) 2014-04-29 08:32 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (700.31 KB, application/zip) 2014-04-29 11:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (382.33 KB, application/zip) 2014-04-29 23:16 PDT, Build Bot	no flags	Details
Patch (50.29 KB, patch) 2014-05-01 00:07 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2014-04-25 04:13:57 PDT

Created attachment 230160 [details] WIP

Gyuyoung Kim

Comment 2 2014-04-28 03:04:19 PDT

Created attachment 230287 [details] WIP-2

Gyuyoung Kim

Comment 3 2014-04-28 16:11:56 PDT

Created attachment 230333 [details] WIP-3

Gyuyoung Kim

Comment 4 2014-04-29 08:32:37 PDT

Created attachment 230378 [details] WIP-4

Build Bot

Comment 5 2014-04-29 11:36:56 PDT

Comment on attachment 230378 [details] WIP-4 Attachment 230378 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4929960376532992 New failing tests: fast/dom/Geolocation/callback-to-deleted-context.html fast/dom/Geolocation/delayed-permission-allowed.html http/tests/notifications/event-listener-crash.html fast/dom/Geolocation/delayed-permission-denied.html platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html fast/dom/Geolocation/argument-types.html fast/dom/Geolocation/callback-exception.html fast/dom/Geolocation/disconnected-frame-already.html fast/dom/Geolocation/coordinates-interface-attributes.html http/tests/notifications/legacy/request-no-callback.html fast/dom/Geolocation/callback-to-remote-context2.html fast/dom/Geolocation/cached-position-iframe.html fast/dom/Geolocation/disconnected-frame-permission-denied.html fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html fast/dom/Geolocation/callback-to-remote-context.html http/tests/notifications/events.html http/tests/notifications/events-in-dictionary.html fast/dom/Window/window-properties-geolocation.html platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html http/tests/notifications/legacy/show.html js/dom/global-constructors-attributes-dedicated-worker.html js/dom/global-constructors-attributes-shared-worker.html http/tests/notifications/legacy/double-show.html http/tests/notifications/legacy/request.html fast/dom/everything-to-string.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html js/dom/global-constructors-attributes.html http/tests/notifications/legacy/events.html http/tests/notifications/show.html fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html

Build Bot

Comment 6 2014-04-29 11:37:11 PDT

Created attachment 230394 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-04-29 23:15:57 PDT

Comment on attachment 230378 [details] WIP-4 Attachment 230378 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6359286301065216 New failing tests: http/tests/notifications/legacy/double-show.html http/tests/notifications/event-listener-crash.html fast/dom/everything-to-string.html fast/dom/Geolocation/argument-types.html fast/dom/Geolocation/callback-exception.html fast/dom/Geolocation/callback-to-remote-context.html fast/dom/Geolocation/coordinates-interface-attributes.html fast/dom/Geolocation/callback-to-remote-context2.html fast/dom/Geolocation/cached-position-iframe.html fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html http/tests/notifications/events.html http/tests/notifications/events-in-dictionary.html fast/dom/Window/window-properties-geolocation.html platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html js/dom/global-constructors-attributes-dedicated-worker.html js/dom/global-constructors-attributes-shared-worker.html fast/dom/Geolocation/callback-to-deleted-context.html platform/mac/fast/speechsynthesis/speech-synthesis-boundary-events.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html js/dom/global-constructors-attributes.html http/tests/notifications/legacy/events.html http/tests/notifications/show.html

Build Bot

Comment 8 2014-04-29 23:16:07 PDT

Created attachment 230461 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Gyuyoung Kim

Comment 9 2014-05-01 00:07:23 PDT

Created attachment 230567 [details] Patch

WebKit Commit Bot

Comment 10 2014-05-01 19:29:21 PDT

Comment on attachment 230567 [details] Patch Clearing flags on attachment: 230567 Committed r168144: <http://trac.webkit.org/changeset/168144>

WebKit Commit Bot

Comment 11 2014-05-01 19:29:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.