Bug 131655

Summary: [EFL][WK2] Use double tap gesture only if page is scalable.
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit EFLAssignee: Eunmi Lee <enmi.lee>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, mcatanzaro, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107631    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Eunmi Lee
Reported 2014-04-14 18:21:32 PDT
Double tap gesture is used to scale page, so it is not necessary if page is not scalable.
Attachments
Patch (5.47 KB, patch)
2014-04-14 18:29 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (5.48 KB, patch)
2014-04-20 22:06 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2014-04-14 18:29:31 PDT
Created attachment 229332 [details] Patch
Jinwoo Song
Comment 2 2014-04-15 02:34:11 PDT
Comment on attachment 229332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229332&action=review > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:536 > + m_doubleTapTimer = 0; s/0/nullptr
Eunmi Lee
Comment 3 2014-04-20 21:51:26 PDT
Comment on attachment 229332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229332&action=review >> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:536 >> + m_doubleTapTimer = 0; > > s/0/nullptr thanks, I will update patch again :)
Eunmi Lee
Comment 4 2014-04-20 22:06:21 PDT
Created attachment 229785 [details] Patch
Michael Catanzaro
Comment 5 2017-03-11 10:33:49 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.