Bug 131276

Summary: Move to using std::unique_ptr for opengl, texmap, transforms and efl in WebCore/platform/graphics.
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebCore Misc.Assignee: Hyowon Kim <hw1008.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bunhere, cdumez, cmarcelo, commit-queue, dino, d-r, esprehn+autocc, gyuyoung.kim, kondapallykalyan, lucas.de.marchi, luiz, mrobinson, noam, ossy, peavo, roger_fong, sergio, svillar, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131360    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hyowon Kim
Reported 2014-04-06 03:49:47 PDT
Move to using std::unique_ptr for opengl, texmap, transforms and efl in WebCore/platform/graphics.
Attachments
Patch (39.31 KB, patch)
2014-04-06 04:07 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Patch (42.15 KB, patch)
2014-04-06 07:51 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Patch (43.51 KB, patch)
2014-04-07 07:09 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hyowon Kim
Comment 1 2014-04-06 04:07:21 PDT
Created attachment 228697 [details] Patch
Hyowon Kim
Comment 2 2014-04-06 07:51:45 PDT
Created attachment 228699 [details] Patch
Hyowon Kim
Comment 3 2014-04-07 07:09:45 PDT
Created attachment 228733 [details] Patch
Darin Adler
Comment 4 2014-04-07 14:52:05 PDT
Comment on attachment 228733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228733&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:39 > + static std::unique_ptr<GraphicsContext3DPrivate> create(GraphicsContext3D*, HostWindow*); Not sure we really need this any more. Caller can just use make_unique. > Source/WebCore/platform/graphics/texmap/TextureMapper.h:119 > + static std::unique_ptr<TextureMapper> create(AccelerationMode newMode = SoftwareMode); Argument name “newMode” should be deleted. Also, I don’t think we really need this. Caller can just use make_unique.
WebKit Commit Bot
Comment 5 2014-04-07 15:22:24 PDT
Comment on attachment 228733 [details] Patch Clearing flags on attachment: 228733 Committed r166889: <http://trac.webkit.org/changeset/166889>
WebKit Commit Bot
Comment 6 2014-04-07 15:22:30 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2014-04-07 23:43:37 PDT
(In reply to comment #5) > (From update of attachment 228733 [details]) > Clearing flags on attachment: 228733 > > Committed r166889: <http://trac.webkit.org/changeset/166889> It broke the WinCairo build - http://build.webkit.org/builders/WinCairo%20Release/builds/38167/steps/compile-webkit/logs/stdio
Sergio Villar Senin
Comment 8 2014-04-10 04:35:34 PDT
It also broke video rendering in WebKitGTK https://bugs.webkit.org/show_bug.cgi?id=131488
Sergio Villar Senin
Comment 9 2014-04-10 04:43:24 PDT
Comment on attachment 228733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228733&action=review > Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-52 > - Why are you removing this?
Martin Robinson
Comment 10 2014-04-10 07:38:32 PDT
This patch sent us comically down the software path unconditionally, because it deleted the TextureMapperGL::create(...) static method, but didn't change the callsite. We've fixed it in https://bugs.webkit.org/show_bug.cgi?id=131471.
Hyowon Kim
Comment 11 2014-04-10 18:24:59 PDT
I'm sorry about the breakage on WinCairo and GTK. And thanks for fixing it.
Martin Robinson
Comment 12 2014-04-10 22:29:47 PDT
(In reply to comment #11) > I'm sorry about the breakage on WinCairo and GTK. > And thanks for fixing it. No problem. The code is cleaner with your changes.
Note You need to log in before you can comment on or make changes to this bug.