Bug 129023

Summary: Correctly install libllvmForJSC.dylib in production builds
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, mrowe, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch
none
the patch
none
the patch
mrowe: review-
the patch mrowe: review+

Filip Pizlo
Reported 2014-02-18 20:45:21 PST
Patch forthcoming.
Attachments
the patch (2.79 KB, patch)
2014-02-18 20:46 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (2.77 KB, patch)
2014-02-18 20:51 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (4.16 KB, patch)
2014-02-18 21:03 PST, Filip Pizlo 		mrowe: review-
DetailsFormatted DiffDiff
the patch (4.63 KB, patch)
2014-02-18 21:29 PST, Filip Pizlo 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-18 20:46:18 PST
Created attachment 224583 [details] the patch
Filip Pizlo
Comment 2 2014-02-18 20:51:04 PST
Created attachment 224584 [details] the patch Fix install path.
Filip Pizlo
Comment 3 2014-02-18 21:03:40 PST
Created attachment 224585 [details] the patch
Mark Rowe (bdash)
Comment 4 2014-02-18 21:15:36 PST
Comment on attachment 224585 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224585&action=review > Source/JavaScriptCore/Configurations/Base.xcconfig:111 > +JAVASCRIPTCORE_LIBRARIES_DIR_macosx = JavaScriptCore.framework/Versions/A/Resources; This isn't the right path. I'd suggest pulling out a JAVASCRIPTCORE_CONTENTS_DIR variable that's JavaScriptCore.framework on iOS and JavaScriptCore.framework/Versions/A on OS X, then just defining JAVASCRIPTCORE_RESOURCES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Resources and JAVASCRIPTCORE_LIBRARIES_DIR = $(JAVASCRIPTCORE_CONTENTS_DIR)/Libraries/. We don't need to repeat the conditionals twice.
Filip Pizlo
Comment 5 2014-02-18 21:29:38 PST
Created attachment 224589 [details] the patch
Filip Pizlo
Comment 6 2014-02-18 21:41:35 PST
Landed in http://trac.webkit.org/changeset/164354
Note You need to log in before you can comment on or make changes to this bug.