Bug 118588

Summary: [WK2] Replace getRect() to pixelSnappedBoundingBox().
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit2Assignee: Eunmi Lee <enmi.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, commit-queue, gyuyoung.kim, noam, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118585    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Eunmi Lee
Reported 2013-07-12 01:29:06 PDT
The Node's getRect() function was removed, so use pixelSnappedBoundingBox() instead. The TOUCH_ADJUSTMENT is enabled in the Qt, so that codes is not used as a default build but it should be fixed.
Attachments
Patch (1.77 KB, patch)
2013-07-12 01:31 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2013-07-15 23:35 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.80 KB, patch)
2013-07-17 23:34 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2013-07-18 00:12 PDT, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2013-07-12 01:31:28 PDT
Created attachment 206512 [details] Patch
Chris Dumez
Comment 2 2013-07-15 23:29:15 PDT
Comment on attachment 206512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206512&action=review > Source/WebKit2/ChangeLog:3 > + Replace getRect() to pixelSnappedBoundingBox(). Missing [WK2] tag.
Eunmi Lee
Comment 3 2013-07-15 23:31:08 PDT
(In reply to comment #2) > (From update of attachment 206512 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206512&action=review > > > Source/WebKit2/ChangeLog:3 > > + Replace getRect() to pixelSnappedBoundingBox(). > > Missing [WK2] tag. Thanks, I will add [WK2]. :)
Eunmi Lee
Comment 4 2013-07-15 23:35:30 PDT
Created attachment 206726 [details] Patch Add [WK2] tag.
Noam Rosenthal
Comment 5 2013-07-17 19:18:00 PDT
Comment on attachment 206726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206726&action=review > Source/WebKit2/ChangeLog:9 > + The Node's getRect() function was removed, so use > + pixelSnappedBoundingBox() instead. Was it removed in a particular revision? Can you name the revision in the changelog?
Eunmi Lee
Comment 6 2013-07-17 23:29:35 PDT
Comment on attachment 206726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206726&action=review >> Source/WebKit2/ChangeLog:9 >> + pixelSnappedBoundingBox() instead. > > Was it removed in a particular revision? Can you name the revision in the changelog? Sure, I will update the changelog.
Eunmi Lee
Comment 7 2013-07-17 23:34:33 PDT
Created attachment 206954 [details] Patch Add revision which removes getRect() to the changelog.
Noam Rosenthal
Comment 8 2013-07-18 00:03:54 PDT
Comment on attachment 206954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206954&action=review > Source/WebKit2/ChangeLog:8 > + The Node's getRect() function was removed in the Say Node::getRect() instead of The Node's getRect() function Otherwise LGTM
Gyuyoung Kim
Comment 9 2013-07-18 00:04:59 PDT
Change component with WebKit2.
Eunmi Lee
Comment 10 2013-07-18 00:12:37 PDT
Created attachment 206955 [details] Patch
WebKit Commit Bot
Comment 11 2013-07-18 01:03:59 PDT
Comment on attachment 206955 [details] Patch Clearing flags on attachment: 206955 Committed r152837: <http://trac.webkit.org/changeset/152837>
WebKit Commit Bot
Comment 12 2013-07-18 01:04:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.