Bug 116530

Summary:

Remove custom code for webkitAudioContext global constructor getter

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, buildbot, commit-queue, eric.carlson, esprehn+autocc, ggaren, glenn, gyuyoung.kim, haraken, jer.noble, laszlo.gombos, rakuco, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

115853

Attachments:

Description	Flags
Patch	none
Patch	buildbot: commit-queue-
Patch	buildbot: commit-queue-
Patch	none
Patch	none

Chris Dumez

Reported 2013-05-21 03:47:45 PDT

webkitAudioContext global constructor getter on DOMWindow.idl currently has a [CustomGetter] because the attribute can be disabled at runtime via the WebAudioEnabled setting. We should use the RuntimeTimeEnabled class for this instead of regular settings and use [EnableAtRuntime] extended attribute so that we can automatically generate the global constructor for AudioContext.

Attachments
Patch (34.53 KB, patch) 2013-05-21 05:12 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (34.93 KB, patch) 2013-05-21 05:16 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Patch (36.23 KB, patch) 2013-05-21 05:59 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Patch (36.23 KB, patch) 2013-05-21 06:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (36.15 KB, patch) 2013-05-22 05:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.