Bug 114958

Summary: WTF::AtomicString::find() should take unsigned 'start' argument
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107093    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2013-04-22 07:35:46 PDT
Fixes the following warnings with -Wshorten-64-to-32: AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); } ~~~~~~~~ ^~~~~ AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~ AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~
Attachments
Patch v1 (2.80 KB, patch)
2013-04-22 07:39 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-04-22 07:39:10 PDT
Created attachment 199027 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2013-04-22 07:45:20 PDT
> WTF::AtomicString::find() should take unsigned 'start' argument Because WTF::String::find() takes an unsigned 'start' argument.
WebKit Commit Bot
Comment 3 2013-04-22 08:30:19 PDT
Comment on attachment 199027 [details] Patch v1 Clearing flags on attachment: 199027 Committed r148884: <http://trac.webkit.org/changeset/148884>
WebKit Commit Bot
Comment 4 2013-04-22 08:30:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.