Bug 109688

Summary: MediaStream API: Use the source id when creating new tracks
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, jochen, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2013-02-13 06:16:44 PST
MediaStream API: Use the source id when creating new tracks
Attachments
Patch (9.23 KB, patch)
2013-02-13 06:21 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (15.99 KB, patch)
2013-02-13 08:53 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2013-02-13 06:21:19 PST
Created attachment 188072 [details] Patch
WebKit Review Bot
Comment 2 2013-02-13 06:25:04 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-02-13 07:14:22 PST
Comment on attachment 188072 [details] Patch Attachment 188072 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16454861 New failing tests: fast/mediastream/MediaStreamTrackList.html
Tommy Widenflycht
Comment 4 2013-02-13 08:53:35 PST
Created attachment 188089 [details] Patch
Tommy Widenflycht
Comment 5 2013-02-13 08:54:52 PST
Added the correct new API to the patch as well as the work-around so that the tests work as intended again.
Adam Barth
Comment 6 2013-02-13 11:31:04 PST
Comment on attachment 188089 [details] Patch ok
WebKit Review Bot
Comment 7 2013-02-13 12:34:17 PST
Comment on attachment 188089 [details] Patch Clearing flags on attachment: 188089 Committed r142773: <http://trac.webkit.org/changeset/142773>
WebKit Review Bot
Comment 8 2013-02-13 12:34:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.