Bug 106743
| Summary: | [EFL] media/video-controls-captions.html fails after r139547 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | lucas.de.marchi, silviapf, vcarbune |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 106653 | ||
| Bug Blocks: | |||
Chris Dumez
<http://trac.webkit.org/changeset/139547> added additional checks to media/video-controls-captions.html and some of them are failing on EFL port:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/media/video-controls-captions-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/media/video-controls-captions-actual.txt
@@ -25,8 +25,8 @@
** Remove DOM node representing the track element **
** Caption button should not be visible as there are no caption tracks.
-EXPECTED (captionsButtonCoordinates[0] <= '0') OK
-EXPECTED (captionsButtonCoordinates[1] <= '0') OK
+EXPECTED (captionsButtonCoordinates[0] <= '0'), OBSERVED '330' FAIL
+EXPECTED (captionsButtonCoordinates[1] <= '0'), OBSERVED '328' FAIL
** Add a text track through JS to the video element **
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Victor Carbune
I'm trying to figure out what happens that triggers this behavior.
I can't think of any reason why MediaControls::closedCaptionTracksChanged()
wouldn't be called in the same way as it on the Chromium port (since it seems to be triggered only in HTMLMediaElement).
Would you be aware of any reason for which m_mediaController->hasClosedCaptions()
would return true instead of false, in the case of removing the single <track>
element from the DOM tree?
Chris Dumez
This failure is no longer reproducible.