Bug 100056

Summary: Handle ArgumentCoder template specializations that take the ArgumentEncoder as a reference
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100094    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2012-10-22 16:57:11 PDT
Handle ArgumentCoder template specializations that take the ArgumentCoder as a reference
Attachments
Patch (7.21 KB, patch)
2012-10-22 16:59 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-22 16:59:24 PDT
Created attachment 170028 [details] Patch
WebKit Review Bot
Comment 2 2012-10-22 17:04:34 PDT
Attachment 170028 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:68: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-10-22 17:51:55 PDT
Comment on attachment 170028 [details] Patch r=me.
WebKit Review Bot
Comment 4 2012-10-22 17:58:24 PDT
Comment on attachment 170028 [details] Patch Clearing flags on attachment: 170028 Committed r132169: <http://trac.webkit.org/changeset/132169>
WebKit Review Bot
Comment 5 2012-10-22 17:58:27 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2012-10-23 02:26:31 PDT
(In reply to comment #4) > (From update of attachment 170028 [details]) > Clearing flags on attachment: 170028 > > Committed r132169: <http://trac.webkit.org/changeset/132169> It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=100094 Could you fix it, please?
Note You need to log in before you can comment on or make changes to this bug.